Skip to content

feat: Badge Variants #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

feat: Badge Variants #1967

merged 1 commit into from
Oct 28, 2025

Conversation

@HoldenFolk
Copy link
Contributor

@HoldenFolk HoldenFolk commented Oct 14, 2025 •
edited
Loading

What does it do?

  • Adds a variant prop to the Badge component. Can control badge colors with default variants
  • Adds deprecation notice to the status component

Why is it needed?

To create stricter configuration of the Badge component for users, and allow us to deprecate the status component.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Issue #1935

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b99d984

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Minor
@strapi/icons Minor
@strapi/ui-primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2025

@HoldenFolk is attempting to deploy a commit to the Strapi Team on Vercel.

A member of the Team first needs to authorize it.

@HoldenFolk HoldenFolk changed the title Badge variants/create badge variants feat: Badge Variants Oct 14, 2025
@oiorain oiorain added pr: feature This PR adds a new feature community labels Oct 15, 2025
HichamELBSI
HichamELBSI requested changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @HoldenFolk, I've put few comments about the current default badge colors

@HoldenFolk
Copy link
Contributor Author

Thanks for your help @HoldenFolk, I've put few comments about the current default badge colors

Thanks for the review and changes @HichamELBSI. Appreciate the guidance!

HichamELBSI
HichamELBSI requested changes Oct 16, 2025
View reviewed changes
HichamELBSI
HichamELBSI previously approved these changes Oct 21, 2025
View reviewed changes
@HichamELBSI HichamELBSI force-pushed the badge-variants/create-badge-variants branch from 224742c to 453db09 Compare October 21, 2025 09:20
@HichamELBSI
Copy link
Collaborator

Please squash your commits so we can move on with this PR.

@HoldenFolk HoldenFolk force-pushed the badge-variants/create-badge-variants branch from 453db09 to c7afa40 Compare October 21, 2025 15:06
@HichamELBSI HichamELBSI force-pushed the badge-variants/create-badge-variants branch from c7afa40 to 19008c2 Compare October 21, 2025 20:33
HichamELBSI
HichamELBSI previously approved these changes Oct 27, 2025
View reviewed changes
@HichamELBSI HichamELBSI added the source: design-system relates to design-system package label Oct 27, 2025
@HichamELBSI
Copy link
Collaborator

Hello @HoldenFolk there is an issue with the linter, you can run yarn lint and check what is happening. Feel free to also run the unit tests to make sure there are no issue.

@HoldenFolk HoldenFolk force-pushed the badge-variants/create-badge-variants branch from 19008c2 to 493f70c Compare October 28, 2025 18:08
@HoldenFolkSagard
Copy link

Hello @HoldenFolk there is an issue with the linter, you can run yarn lint and check what is happening. Feel free to also run the unit tests to make sure there are no issue.

Fixed the linting error @HichamELBSI . The unit tests fail but it is on the DatePicker tests, which also appear to fail on main. Not sure if this is an issue?

@HichamELBSI HichamELBSI force-pushed the badge-variants/create-badge-variants branch from 493f70c to b99d984 Compare October 28, 2025 18:52
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@HichamELBSI HichamELBSI merged commit d48bf58 into strapi:main Oct 28, 2025
6 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HichamELBSI HichamELBSI HichamELBSI approved these changes

Assignees

No one assigned

Labels

community pr: feature This PR adds a new feature source: design-system relates to design-system package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HoldenFolk @HichamELBSI @HoldenFolkSagard @oiorain